feat: prices GET endpoint #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
force-pushed
the
raphodn/price-get-endpoint
branch
from
7e749bc to
f6ae9aa
Compare
raphodn
force-pushed
the
raphodn/price-create-endpoint
branch
from
118a132 to
f62ee3e
Compare
raphodn
force-pushed
the
raphodn/price-get-endpoint
branch
from
8e28b98 to
162f6aa
Compare
raphodn
commented
Nov 15, 2023
app/api.py
Outdated
| @@ -124,6 +126,12 @@ async def authentication(form_data: Annotated[OAuth2PasswordRequestForm, Depends | |||
| raise HTTPException(status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, detail="Server error") | |||
|
|
|||
|
|
|||
| @app.get("/prices", response_model=List[schemas.PriceBase]) | |||
There was a problem hiding this comment.
@raphael0202 this is a simple v1, but I feel we'll need to have improvements like
- using fastapi-filters to have more complex filtering
- pagination & limit parameters
- should the endpoint answer a list, or a dict with keys like "data" ?
There was a problem hiding this comment.
pagination would be good to have indeed!
Better have a dict as a response, so we can add other fields if needed.
like {"prices": [...]}
There was a problem hiding this comment.
in Django Rest Framework the following format is returned
There was a problem hiding this comment.
I found fastapi-pagination, I'll add it in a follow-up PR
raphael0202
reviewed
Nov 15, 2023
raphodn
force-pushed
the
raphodn/price-get-endpoint
branch
from
162f6aa to
47c31bd
Compare
This was referenced Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
GETendpoint/pricesTodo (futur PRs)
fastapi-filterfor additional/complex filteringfastapi-pagination