Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compress proof image before upload #41

Merged
merged 3 commits into from
Dec 20, 2023
Merged

feat: compress proof image before upload #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b72a658
Add compressor.js library
raphodn Dec 20, 2023
f5e29c7
Compress proof image before upload
raphodn Dec 20, 2023
28c1eec
Form: hide image size
raphodn Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"dependencies": {
"@vueuse/core": "^10.6.1",
"@vueuse/integrations": "^10.6.1",
"compressorjs": "^1.2.1",
"html5-qrcode": "^2.3.8",
"universal-cookie": "^6.1.1",
"vue": "^3.3.9",
Expand Down
51 changes: 37 additions & 14 deletions src/views/AddPriceSingle.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
<v-divider></v-divider>
<v-card-text>
<v-file-input
show-size
accept="image/*"
label="Proof"
v-model="proofImage"
Expand Down Expand Up @@ -136,10 +135,19 @@
</template>

<script>
import Compressor from 'compressorjs'
import api from '../services/api'
import BarcodeScanner from '../components/BarcodeScanner.vue'
import LocationSelector from '../components/LocationSelector.vue'

Compressor.setDefaults({
checkOrientation: true, // default
retainExif: true,
quality: 0.6,
// mimeType: 'image/webp',
Copy link
Member Author

@raphodn raphodn Dec 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raphael0202 I commented it out because I have issues when the config is set to webp: the image is compressed, and the output is displayed, but it is stored without an extension ("None" instead). It's probably due to the backend image mgmt, so we'll need a seperate PR to fix it ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done here ! #44

maxWidth: 3000
})

export default {
components: {
BarcodeScanner,
Expand Down Expand Up @@ -185,19 +193,34 @@ export default {
},
uploadProof() {
this.createProofLoading = true
api
.createProof(this.proofImage[0])
.then((data) => {
this.addPriceSingleForm.proof_id = data['id']
this.proofImagePreview = URL.createObjectURL(this.proofImage[0])
this.createProofLoading = false
this.proofSuccessMessage = true
})
.catch((error) => {
alert('Error: server error')
console.log(error)
this.createProofLoading = false
})
new Promise((resolve, reject) => {
new Compressor(this.proofImage[0], {
success: resolve,
error: reject
});
})
.then((proofImageCompressed) => {
api
.createProof(proofImageCompressed)
.then((data) => {
this.addPriceSingleForm.proof_id = data['id']
this.proofImagePreview = URL.createObjectURL(proofImageCompressed)
this.createProofLoading = false
this.proofSuccessMessage = true
})
.catch((error) => {
alert('Error: server error')
console.log(error)
this.createProofLoading = false
})
})
.catch((error) => {
alert('Error: compression')
console.log(error)
})
// .finally(() => {
// console.log('Compress complete')
// })
},
createPrice() {
this.createPriceLoading = true
Expand Down
18 changes: 18 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,11 @@ autoprefixer@^10.4.16:
picocolors "^1.0.0"
postcss-value-parser "^4.2.0"

blueimp-canvas-to-blob@^3.29.0:
version "3.29.0"
resolved "https://registry.yarnpkg.com/blueimp-canvas-to-blob/-/blueimp-canvas-to-blob-3.29.0.tgz#d965f06cb1a67fdae207a2be56683f55ef531466"
integrity sha512-0pcSSGxC0QxT+yVkivxIqW0Y4VlO2XSDPofBAqoJ1qJxgH9eiUDLv50Rixij2cDuEfx4M6DpD9UGZpRhT5Q8qg==

browserslist@^4.21.10:
version "4.21.10"
resolved "https://registry.npmjs.org/browserslist/-/browserslist-4.21.10.tgz"
Expand All @@ -300,6 +305,14 @@ caniuse-lite@^1.0.30001538:
resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001538.tgz"
integrity sha512-HWJnhnID+0YMtGlzcp3T9drmBJUVDchPJ08tpUGFLs9CYlwWPH2uLgpHn8fND5pCgXVtnGS3H4QR9XLMHVNkHw==

compressorjs@^1.2.1:
version "1.2.1"
resolved "https://registry.yarnpkg.com/compressorjs/-/compressorjs-1.2.1.tgz#4dee18ef5032f8166bd0a3258f045eda2cd07671"
integrity sha512-+geIjeRnPhQ+LLvvA7wxBQE5ddeLU7pJ3FsKFWirDw6veY3s9iLxAQEw7lXGHnhCJvBujEQWuNnGzZcvCvdkLQ==
dependencies:
blueimp-canvas-to-blob "^3.29.0"
is-blob "^2.1.0"

cookie@^0.5.0:
version "0.5.0"
resolved "https://registry.npmjs.org/cookie/-/cookie-0.5.0.tgz"
Expand Down Expand Up @@ -384,6 +397,11 @@ html5-qrcode@^2.3.8:
resolved "https://registry.yarnpkg.com/html5-qrcode/-/html5-qrcode-2.3.8.tgz#0b0cdf7a9926cfd4be530e13a51db47592adfa0d"
integrity sha512-jsr4vafJhwoLVEDW3n1KvPnCCXWaQfRng0/EEYk1vNcQGcG/htAdhJX0be8YyqMoSz7+hZvOZSTAepsabiuhiQ==

is-blob@^2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/is-blob/-/is-blob-2.1.0.tgz#e36cd82c90653f1e1b930f11baf9c64216a05385"
integrity sha512-SZ/fTft5eUhQM6oF/ZaASFDEdbFVe89Imltn9uZr03wdKMcWNVYSMjQPFtg05QuNkt5l5c135ElvXEQG0rk4tw==

isexe@^2.0.0:
version "2.0.0"
resolved "https://registry.npmjs.org/isexe/-/isexe-2.0.0.tgz"
Expand Down