Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ContributionAssistant): Avoid wait on auto detection for old proofs #1331

Merged
merged 1 commit into from
Jan 26, 2025
Merged

refactor(ContributionAssistant): Avoid wait on auto detection for old proofs #1331

merged 1 commit into from
Jan 26, 2025

Conversation

TTalex
Copy link
Collaborator

@TTalex TTalex commented Jan 26, 2025

What

  • Do not try to fetch price tags on receipts
  • Only try to fetch price tags once on proofs older than a day
  • This avoids the unnecessary wait message on step 2 (see issue below for screenshot)

Fixes bug(s)

@raphodn raphodn merged commit a7d6a5a into master Jan 26, 2025
7 of 8 checks passed
@raphodn raphodn deleted the ca-avoid-waiting branch January 26, 2025 16:34
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jan 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphodn raphodn raphodn approved these changes

Assignees

@TTalex TTalex

Labels
None yet
Projects
💸 Open Prices
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't display "Automatic detection is running" if proof is old
2 participants
@TTalex @raphodn