Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Challenge): Match btn style with multiple proof upload #1281

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

TTalex
Copy link
Collaborator

@TTalex TTalex commented Jan 18, 2025

What

  • Since buttons do the same thing, we might as well make them look the same
  • I kept the "Add pictures" denomination, finding it clearer than "Add proof"

@@ -19,6 +19,7 @@
color="primary"
variant="flat"
:block="!$vuetify.display.smAndUp"
prepend-icon="mdi-image-plus"
to="/proofs/add/multiple"
>
{{ $t('Challenge.StepTakePictures.AddPictures') }}
Copy link
Member

@raphodn raphodn Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminds me that when you demoed this and I saw "Pictures"

  • I thought it sounded better than Images
  • and that we should replace elsewhere in the app the "Images" by "Pictures" (right now we have 3 wordings for the same thing : Proof, Image & Picture I believe)

@raphodn raphodn merged commit 67c4f28 into master Jan 18, 2025
6 of 7 checks passed
@raphodn raphodn deleted the challenge-btn-style branch January 18, 2025 21:14
@raphodn raphodn linked an issue Jan 18, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

A page for community challenges 🏆
2 participants