Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add links related to open food facts in settings route. #535

Closed
wants to merge 3 commits into from

Conversation

Sudhanva-Nadiger
Copy link
Contributor

What

  • Add download links for different platforms
  • Add donate link
  • Add join community links and discover projects links
  • Add a footer with all social-media links

Screenshot

image
image

Fixes bug(s)

Part of

- added DiscoverProjects, JoinTheCommunity, OpenFoodFacts footer
components
- made responsive for mobile layout.
@Sudhanva-Nadiger
Copy link
Contributor Author

@alexfauquette I got confused about where to add the share link of hunger games! if u explain to me that I will ad that too! Thanks.

</div>
</Stack>
<Divider sx={{ width: "100%" }} light />
<FooterWithLinks />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

Maybe a slight improvement could be to move all the files you created to a folder src/components/Footer such that you can also reuse it in src/pages/home

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okayyyyy !!!! I will do that. Thanks <3

@alexfauquette
Copy link
Member

For the item

Add a link to share Hunger Games with friends, with a prepopulated explainer

I don't no. Maybe @teolemon have an idea

@Sudhanva-Nadiger
Copy link
Contributor Author

@alexfauquette sir I have created another pr, don't know why that automatically get added to this pr .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants