Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: base of project #9

Merged
merged 12 commits into from
Jun 16, 2022
Merged

build: base of project #9

merged 12 commits into from
Jun 16, 2022

Conversation

sumit-158
Copy link
Member

@sumit-158 sumit-158 commented Jun 8, 2022

@sumit-158 sumit-158 linked an issue Jun 8, 2022 that may be closed by this pull request
@sumit-158 sumit-158 changed the title Setup basic project build: base of project Jun 8, 2022
@sumit-158 sumit-158 requested review from alexgarel and teolemon June 8, 2022 14:24
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumit-158 cool start.

There are changes to be made, but simple ones.

Also in the server/ directory there should be a requirements.txt giving libraries to install with their versions (or poetry file if you prefer, but it's a bit more complex).

client/.gitignore Outdated Show resolved Hide resolved
client/README.md Outdated Show resolved Hide resolved
client/android/.gitignore Outdated Show resolved Hide resolved
client/.gitignore Outdated Show resolved Hide resolved
client/.gitignore Outdated Show resolved Hide resolved
server/server/settings.py Outdated Show resolved Hide resolved
@sumit-158 sumit-158 requested a review from alexgarel June 16, 2022 11:04
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve so you can merge when you're ready.

But please before:

  • I made a suggestion
  • you should put at least django dependency in requirements.txt ( Django==4.0.5 )

community_portal/.env Outdated Show resolved Hide resolved
@sumit-158
Copy link
Member Author

  • you should put at least django dependency in requirements.txt ( Django==4.0.5 )
    its already there !

@sumit-158 sumit-158 merged commit ce70309 into main Jun 16, 2022
@alexgarel
Copy link
Member

alexgarel commented Jun 16, 2022

  • you should put at least django dependency in requirements.txt ( Django==4.0.5 )

its already there !

Sorry @sumit-158, it's github interface that makes me confused:

image

@teolemon teolemon deleted the dev branch June 22, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Setup basic project Django + flutter welcome page
2 participants