Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: yaml validation #96

Merged
merged 1 commit into from
Nov 1, 2023
Merged

fix: yaml validation #96

merged 1 commit into from
Nov 1, 2023

Conversation

d-jeffery
Copy link
Collaborator

@d-jeffery d-jeffery commented Nov 1, 2023 •
edited
Loading

Description

  • Allow spaces after model and trailing spaces after the |
  • Added required fields
  • Improved diagnostic location for array items

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery marked this pull request as ready for review November 1, 2023 19:55
@d-jeffery d-jeffery requested a review from a team as a code owner November 1, 2023 19:55
@rhamzeh rhamzeh added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit e2b29bc Nov 1, 2023
@rhamzeh rhamzeh deleted the fix/yaml-validation branch November 1, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-jeffery @rhamzeh