Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python-sdk): batch_check updates #228

Merged
merged 2 commits into from
Nov 2, 2023
Merged

feat(python-sdk): batch_check updates #228

merged 2 commits into from
Nov 2, 2023

Conversation

booniepepper
Copy link
Contributor

@booniepepper booniepepper commented Oct 30, 2023 •
edited
Loading

Description

  • feat(python-sdk): run sync batch_check with ThreadPoolExecutor for parallelism
  • feat(python-sdk): use asyncio semaphore for streaming batch check

References

Generates openfga/python-sdk#41

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@booniepepper booniepepper requested a review from a team as a code owner October 30, 2023 20:59
@booniepepper booniepepper mentioned this pull request Oct 30, 2023
Merged
4 tasks
@booniepepper booniepepper force-pushed the feat/python-sync-parallel-batch-check branch from 6ea1443 to 34f775e Compare November 1, 2023 21:05
@booniepepper booniepepper changed the title feat(python-sdk): run sync batch_check with ThreadPoolExecutor for parallelism feat(python-sdk): batch_check updates Nov 2, 2023
@booniepepper booniepepper force-pushed the feat/python-sync-parallel-batch-check branch from ad65862 to 1eeb2b5 Compare November 2, 2023 19:18
@booniepepper booniepepper requested a review from rhamzeh November 2, 2023 19:50
@rhamzeh rhamzeh added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 660bb33 Nov 2, 2023
6 checks passed
@rhamzeh rhamzeh deleted the feat/python-sync-parallel-batch-check branch November 2, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booniepepper @rhamzeh