Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openfga): allow nav link in accordion #921

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

ttrzeng
Copy link
Contributor

@ttrzeng ttrzeng commented Jan 3, 2025

Description

In openFGA docs, the links in the summary of the accordion is overlapped by the function of the accordion toggle. This PR fixes that to ensure all URLs in the summary of accordion is clickable and will navigate to the url

References

Closes #920

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ttrzeng ttrzeng requested review from rhamzeh and pdillon January 3, 2025 20:45
@ttrzeng ttrzeng requested review from a team as code owners January 3, 2025 20:45
Copy link
Contributor

github-actions bot commented Jan 3, 2025

PR Preview Action v1.4.8
🚀 Deployed preview to https://openfga.github.io/openfga.dev/pr-preview/pr-921/
on branch gh-pages at 2025-01-03 20:49 UTC

@rhamzeh rhamzeh merged commit e53da30 into main Jan 6, 2025
13 checks passed
@rhamzeh rhamzeh deleted the fix/allow-navigation-link-in-accordion branch January 6, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concepts Page: Unable to click on links in the summary of a concept
2 participants