Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: create github release prior to publishing #56

Merged
merged 1 commit into from
Sep 10, 2024
Merged

ci: create github release prior to publishing #56

merged 1 commit into from
Sep 10, 2024

Conversation

ewanharris
Copy link
Member

Description

Given that we're uploading the result into a release, that needs to exist first

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris
ci: create github release prior to publishing
46dbb58 
Given that we're uploading the result into a release, that needs to exist first
@ewanharris ewanharris requested review from a team as code owners September 10, 2024 09:04
@ewanharris ewanharris merged commit 0261cec into main Sep 10, 2024
14 checks passed
@ewanharris ewanharris deleted the ci/create-release-first branch September 10, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewanharris @rhamzeh