This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
Part one of converting OFC to go modules #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
first part of #687 |
This will initialise a module in each function/folder. This needs to be merged before modules can start to manage dependancies because otherwise you get a duplicate definition error as each function that imports anything from the ofc repo (from github in its gopkg) will pull the whole repo in, not just the module it wants (the SDK for example) so we need a go mod in each folder to avoid it existing twice in the dependency tree for the function. Once this is in, each module can be converted to go modules and remove the use of dep Signed-off-by: Alistair Hey <[email protected]>
Waterdrips
force-pushed
the
waterdrips-part-1-go-mod
branch
from
31e61eb to
a6838e2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will initialise a module in each function/folder. This needs to be
merged before modules can start to manage dependancies because otherwise
you get a duplicate definition error as each function that imports
anything from the ofc repo (from github in its gopkg) will pull the
whole repo in, not just the module it wants (the SDK for example) so we
need a go mod in each folder to avoid it existing twice in the
dependency tree for the function.
Once this is in, each module can be converted to go modules and remove
the use of dep
Signed-off-by: Alistair Hey [email protected]
How Has This Been Tested?
I added a replace directive for the local module on disk and tested the go mod vendor and go mod tidy calls worked and started to manage deps. Without the replace we got the errors mentioned above
How are existing users impacted? What migration steps/scripts do we need?
no changes. This is background work to upgrade to go modules and is required to make the switch.
Checklist:
I have:
git commit -s