This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
[Feature request] Support Github Orgs as Customers in edge-auth #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Commit adds support for using a github Organisation as a "Customer" in the customers file. This means users can manage their access controls using github organisations rather than having to add/remove from the customers file. Tested by only having an organisation in the Customers file, checking that I didn't get access with the previous version of edge-auth, then changing to use my new version and I was issued a token and could access the dashboard Signed-off-by: Alistair Hey <[email protected]>
alexellis
changed the title
|
Hi @Waterdrips, changes like this which affect the roadmap and security need to be properly proposed as issues before being worked on. See the contribution guide about making proposals, please include the use-case, current workarounds and why you feel this change is required. https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md#i-have-a-great-idea Alex |
|
/close see #603 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Commit adds support for using a github Organisation as a "Customer"
in the customers file. This means users can manage their access controls
using github organisations rather than having to add/remove from the
customers file.
Signed-off-by: Alistair Hey [email protected]
How Has This Been Tested?
Tested by only having an organisation in the Customers file, checking
that I didnt get access with the previous version of edge-auth, then
changing to use my new version and I was issued a token and could access
the dashboard
Unit tests written
How are existing users impacted? What migration steps/scripts do we need?
Any users who have an organisation in their Customers file will give access to public members of that organisation if they don't already exist in the ACL.
Users who wish to manage their ACL using github organisations can now use the organisation in the Customers file. Then only need to add/remove users from the organisation to give access.
Checklist:
I have:
git commit -s