-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] refactor: refactoring Pagination component #2837
[BD-46] refactor: refactoring Pagination component #2837
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
OLD PR: #1911 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/chip-searchfield-pagination #2837 +/- ##
=======================================================================
+ Coverage 92.82% 92.89% +0.06%
=======================================================================
Files 235 246 +11
Lines 4237 4276 +39
Branches 1029 1032 +3
=======================================================================
+ Hits 3933 3972 +39
Misses 300 300
Partials 4 4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid refactor and improvements to the Pagination
component. This will be solving a long-standing style bug with our Enterprise MFE's dynamic theming solution, too :) 💯
adb5831
into
openedx:release/chip-searchfield-pagination
Description
Refactors Pagination component to fix its style and API issues (and to improve it overall to ease maintenance).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist