-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] docs: remove technical documentation label update readme #2814
[BD-46] docs: remove technical documentation label update readme #2814
Conversation
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the pull request, @khudym! When this pull request is ready, tag your edX technical lead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct the order of elements in the pull request title, we follow this format - [BD-46] docs: remove technical documentation label update readme
.
@@ -10,9 +10,6 @@ function HomePage() { | |||
{/* eslint-disable-next-line react/jsx-pascal-case */} | |||
<SEO title="Home" /> | |||
<div className="bg-dark text-white text-center py-5"> | |||
<p className="x-small text-uppercase text-monospace mb-0"> | |||
Technical Documentation{' '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still have "Technical Documentation" on the component pages, please remove it
05a7cd1
to
89fd961
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2814 +/- ##
==========================================
- Coverage 92.89% 92.83% -0.07%
==========================================
Files 235 235
Lines 4333 4240 -93
Branches 1053 1029 -24
==========================================
- Hits 4025 3936 -89
+ Misses 304 300 -4
Partials 4 4 ☔ View full report in Codecov by Sentry. |
@khudym 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 22.0.0-alpha.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 21.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Issue
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist