Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] refactor: created missing design tokens #2811

Conversation

PKulkoRaccoonGang
Copy link
Contributor

Description

  • go through and check all the variables;
  • add the missing ones right away;
  • create an empty document with a simple structure so that we can add tokens there in the future and remember to add them.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Nov 15, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 15, 2023

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft November 15, 2023 08:40
Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b3ee550
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6555fb46a02c6000095548ae
😎 Deploy Preview https://deploy-preview-2811--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (9af9a64) to head (b3ee550).
Report is 626 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #2811   +/-   ##
=======================================
  Coverage   93.28%   93.29%           
=======================================
  Files         215      215           
  Lines        3635     3638    +3     
  Branches      898      898           
=======================================
+ Hits         3391     3394    +3     
  Misses        239      239           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/create-missing-design-tokens branch from 217bea1 to 01b666b Compare November 15, 2023 19:20
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/create-missing-design-tokens branch from 01b666b to 5e60d7d Compare November 15, 2023 19:52
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review November 16, 2023 11:21
@viktorrusakov viktorrusakov merged commit 36c80fe into openedx:alpha Nov 16, 2023
8 checks passed
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@openedx-semantic-release-bot

🎉 This PR is included in version 22.0.0-alpha.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

PKulkoRaccoonGang added a commit that referenced this pull request Aug 1, 2024
* refactor: created missing design tokens

* refactor: added missing tokens for the Nav component

* refactor: added missing tokens for the Tabs component

* refactor: added missing tokens for the Breadcrumbs component

* refactor: code refactoring
PKulkoRaccoonGang added a commit that referenced this pull request Aug 4, 2024
* refactor: created missing design tokens

* refactor: added missing tokens for the Nav component

* refactor: added missing tokens for the Tabs component

* refactor: added missing tokens for the Breadcrumbs component

* refactor: code refactoring
PKulkoRaccoonGang added a commit that referenced this pull request Aug 5, 2024
* refactor: created missing design tokens

* refactor: added missing tokens for the Nav component

* refactor: added missing tokens for the Tabs component

* refactor: added missing tokens for the Breadcrumbs component

* refactor: code refactoring
@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants