-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] refactor Pagination component #1911
Closed
viktorrusakov
wants to merge
7
commits into
openedx:master
from
raccoongang:rusakov/attempt-to-refactor-pagination
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7eee4c2
feat: refactor Pagination
viktorrusakov e7d7f98
test: refactor Pagination tests
viktorrusakov 1218110
refactor: clean up after rebase
a8e5748
refactor: small SCSS and code style refactoring
viktorrusakov 6247545
test: improve code quality in Pagination tests
viktorrusakov fb4efe5
fix: update tests
viktorrusakov ba7deae
chore: update imports and prop types
viktorrusakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
import React, { useContext } from 'react'; | ||
import { useMediaQuery } from 'react-responsive'; | ||
import PaginationContext from './PaginationContext'; | ||
import { ELLIPSIS } from './constants'; | ||
import { | ||
PreviousPageButton, | ||
NextPageButton, | ||
PageOfCountButton, | ||
PageButton, | ||
Ellipsis, | ||
} from './subcomponents'; | ||
import breakpoints from '../utils/breakpoints'; | ||
import newId from '../utils/newId'; | ||
|
||
function PaginationPages() { | ||
const { displayPages } = useContext(PaginationContext); | ||
const isMobile = useMediaQuery({ maxWidth: breakpoints.extraSmall.maxWidth }); | ||
|
||
if (isMobile) { | ||
return <PageOfCountButton />; | ||
} | ||
|
||
return ( | ||
<> | ||
{displayPages.map((pageIndex) => { | ||
if (pageIndex === ELLIPSIS) { | ||
return <Ellipsis key={newId('pagination-ellipsis-')} />; | ||
} | ||
return <PageButton key={pageIndex} pageNum={pageIndex + 1} />; | ||
})} | ||
</> | ||
); | ||
} | ||
|
||
export default function DefaultPagination() { | ||
return ( | ||
<ul className="pagination"> | ||
<PreviousPageButton /> | ||
<PaginationPages /> | ||
<NextPageButton /> | ||
</ul> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import React from 'react'; | ||
import { PreviousPageButton, NextPageButton } from './subcomponents'; | ||
|
||
export default function MinimalPagination() { | ||
return ( | ||
<ul className="pagination"> | ||
<PreviousPageButton /> | ||
<NextPageButton /> | ||
</ul> | ||
); | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add
propTypes
for this component?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component does not receive any props, so I don't think
propTypes
are needed here