refactor: order collections by primary key

openedx · Aug 23, 2024 · cdc7dd2 · cdc7dd2
1 parent 2a0bc53
commit cdc7dd2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/openedx_learning/apps/authoring/collections/api.py b/openedx_learning/apps/authoring/collections/api.py
@@ -78,7 +78,8 @@ def get_learning_package_collections(learning_package_id: int) -> QuerySet[Colle
     """
     return Collection.objects \
                      .filter(learning_package_id=learning_package_id, enabled=True) \
-                     .select_related("learning_package")
+                     .select_related("learning_package") \
+                     .order_by('pk')
 
 
 def get_collections(enabled: bool | None = None) -> QuerySet[Collection]:
@@ -88,4 +89,4 @@ def get_collections(enabled: bool | None = None) -> QuerySet[Collection]:
     qs = Collection.objects.all()
     if enabled is not None:
         qs = qs.filter(enabled=enabled)
-    return qs.select_related("learning_package")
+    return qs.select_related("learning_package").order_by('pk')
diff --git a/tests/openedx_learning/apps/authoring/collections/test_api.py b/tests/openedx_learning/apps/authoring/collections/test_api.py
@@ -120,7 +120,7 @@ def test_get_all_collections(self):
             self.collection2,
             self.collection3,
             self.disabled_collection,
-        ], ordered=False)
+        ], ordered=True)
 
     def test_get_all_enabled_collections(self):
         """
@@ -131,7 +131,7 @@ def test_get_all_enabled_collections(self):
             self.collection1,
             self.collection2,
             self.collection3,
-        ], ordered=False)
+        ], ordered=True)
 
     def test_get_all_disabled_collections(self):
         """