-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for tutor 19 #140
base: main
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @kaustavb12! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaustavb12 have you tested if the harmony plugin can handle instances created by tutor 19?
Yes. This sandbox instance(private-ref) was created with this PR branch along with tutor 19. Please take a look. |
Seems pretty straight forward. Is there something we should be wary of after Tutor removed ES from core? |
I think ES related config and code should eventually be removed from Harmony. We also need to be careful about version compatibility, i.e. upto what version of Harmony would support older Open edX releases with ES, etc. But for this PR, my goal was to simply make sure we are able to correctly spin up Sumac instances using Harmony. I simply set |
Description
Adds support for tutor 19.
Other information
Private ref : BB-9353