refactor: address review feedback

openedx · Jan 17, 2024 · 574b74f · 574b74f
1 parent acec545
commit 574b74f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/Discovery/Discovery/Data/DiscoveryRepository.swift b/Discovery/Discovery/Data/DiscoveryRepository.swift
@@ -73,11 +73,7 @@ public class DiscoveryRepository: DiscoveryRepositoryProtocol {
 
     public func enrollToCourse(courseID: String) async throws -> Bool {
         let enroll = try await api.request(DiscoveryEndpoint.enrollToCourse(courseID: courseID))
-        if enroll.statusCode == 200 {
-            return true
-        } else {
-            return false
-        }
+        return enroll.statusCode == 200
     }
 }
 

diff --git a/Discovery/Discovery/Data/Network/DiscoveryEndpoint.swift b/Discovery/Discovery/Data/Network/DiscoveryEndpoint.swift
@@ -23,7 +23,7 @@ enum DiscoveryEndpoint: EndPointType {
             return "/api/courses/v1/courses/"
         case .getCourseDetail(courseID: let courseID, _):
             return "/api/courses/v1/courses/\(courseID)"
-        case .enrollToCourse(courseID: _):
+        case .enrollToCourse:
             return "/api/enrollment/v1/enrollment"
         }
     }
@@ -32,7 +32,7 @@ enum DiscoveryEndpoint: EndPointType {
         switch self {
         case .getDiscovery, .searchCourses:
             return .get
-        case .getCourseDetail(courseID: _, username: _):
+        case .getCourseDetail:
             return .get
         case .enrollToCourse:
             return .post

diff --git a/Discovery/Discovery/Presentation/WebDiscovery/URL+PathExtension.swift b/Discovery/Discovery/Presentation/WebDiscovery/URL+PathExtension.swift
@@ -13,7 +13,7 @@ public extension URL {
     }
 
     var isValidAppURLScheme: Bool {
-        return scheme ?? "" == URIString.appURLScheme.rawValue 
+        return scheme ?? "" == URIString.appURLScheme.rawValue
     }
 
     var queryParameters: [String: Any]? {