Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add translation removal instructions to repo archive process #557

Merged

Conversation

brian-smith-tcril
Copy link
Contributor

No description provided.

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog entry too?

@@ -88,6 +88,14 @@ These steps should be followed for all repos within the Open edX organization (f

- Move the repository to the openedx-unsupported organization

- Remove the repo from ``openedx-translations`` and Transifex

- Remove the repo entry from the ``extract-translation-source-files`` workflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, this workflow is in the openedx-translations repo? (and the following step same question)


- Remove the repo directory from the ``translations`` directory

- Remove the repo resource from the ``openedx-translations`` project on Transifex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to say "ask a Transifex admin to..."? I don't think most people will be able to do this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I'd like to be more specific than just saying "ask an admin" though since I'm not sure if everyone will know who is admin and therefore who to ask. I'm thinking either point people to the #wg-translations channel on slack or suggest they open a request on the axim-engineering repo. Thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an axim-engineering request. And maybe as part of this PR, we do an audit of admins on Transifex and remove people who aren't around or who don't need access and add a couple more Axim folx.

@sarina
Copy link
Contributor

sarina commented May 17, 2024

@brian-smith-tcril - can we wrap this one up?

@brian-smith-tcril brian-smith-tcril force-pushed the remove-archived-repo-translations branch from c673a98 to f22d930 Compare May 20, 2024 13:11
@brian-smith-tcril brian-smith-tcril force-pushed the remove-archived-repo-translations branch from f22d930 to 0b9b424 Compare May 20, 2024 13:14
@brian-smith-tcril
Copy link
Contributor Author

@sarina I think my latest changes should address all the previous comments.

image

@sarina sarina merged commit 02559a1 into openedx:master May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants