Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add integration count number #414

Merged
merged 2 commits into from
Sep 9, 2024
Merged

fix: add integration count number #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1e3f51
fix: add integration count number
kiram15 Sep 9, 2024
bce476d
fix: PR request
kiram15 Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Configuration/Customers/CustomerDetailView/CustomerIntegrations.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,16 @@ const CustomerIntegrations = ({
const { ADMIN_PORTAL_BASE_URL } = getConfig();
const ssoDateText = ({ sso }) => (`Created ${formatDate(sso?.created)} • Last modified ${formatDate(sso?.modifed)}`);
const configDateText = ({ config }) => (`Created ${formatDate(config?.created)} • Last modified ${formatDate(config?.lastModifiedAt)}`);
let integrationCount = (activeSSO ? activeSSO.length : 0) + (activeIntegrations ? activeIntegrations.length : 0);
if (apiCredentialsEnabled) {
integrationCount++;
}

return (
<div>
{(activeSSO || activeIntegrations || apiCredentialsEnabled) && (
{(integrationCount > 0) && (
<div>
<h2>Associated integrations</h2>
<h2>Associated integrations ({integrationCount})</h2>
<hr />
{activeSSO && activeSSO.map((sso) => (
<CustomerViewCard
Expand Down
3 changes: 1 addition & 2 deletions src/Configuration/Customers/CustomerDetailView/tests/CustomerViewIntegrations.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ describe('CustomerViewIntegrations', () => {
</IntlProvider>,
);
await waitFor(() => {
expect(screen.getByText('Associated integrations')).toBeInTheDocument();

expect(screen.getByText('Associated integrations (4)')).toBeInTheDocument();
expect(screen.getByText('SSO')).toBeInTheDocument();
expect(screen.getByText('Orange cats rule')).toBeInTheDocument();
expect(screen.getAllByText('Created September 15, 2024 • Last modified September 15, 2024')).toHaveLength(3);
Expand Down