Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paragon table deprecation migration to DataTable #256

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Paragon table deprecation migration to DataTable #256

merged 3 commits into from
Jul 27, 2022

Conversation

abdullahwaheed
Copy link
Contributor

Ticket

Migrate off deprecated Paragon components

What has changed

Removed deprecated Table component of paragon and updated it with DataTable

References

Paragon Table
Paragon DataTable

@abdullahwaheed abdullahwaheed requested a review from a team June 17, 2022 14:38
@abdullahwaheed abdullahwaheed self-assigned this Jun 17, 2022
@codecov
Copy link

codecov bot commented Jun 17, 2022 •
edited
Loading

Codecov Report

Merging #256 (a2b4aab) into master (7442a7f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   82.90%   82.90%           
=======================================
  Files          81       81           
  Lines        1784     1784           
  Branches      430      430           
=======================================
  Hits         1479     1479           
  Misses        304      304           
  Partials        1        1
Impacted Files Coverage Δ
src/users/account-actions/PasswordHistory.jsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7442a7f...a2b4aab. Read the comment docs.

davidjoy
davidjoy approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@davidjoy davidjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fine change - the owning team should also review so they're aware of the change, it should be tested by Fed-BOM and we can get it in. I did a cursory review.

@abdullahwaheed
Copy link
Contributor Author

tested on local, working fine
image

Ali-D-Akbar
Ali-D-Akbar approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@Ali-D-Akbar Ali-D-Akbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abdullahwaheed abdullahwaheed merged commit dd082ff into master Jul 27, 2022
@arbrandes arbrandes mentioned this pull request Nov 16, 2022
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ali-D-Akbar Ali-D-Akbar Ali-D-Akbar approved these changes

@davidjoy davidjoy davidjoy approved these changes

Assignees

@abdullahwaheed abdullahwaheed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abdullahwaheed @davidjoy @Ali-D-Akbar @jmbowman