feat: upgrade react router to v6 #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #850 +/- ##
==========================================
+ Coverage 66.97% 67.17% +0.19%
==========================================
Files 128 128
Lines 3201 3211 +10
Branches 927 927
==========================================
+ Hits 2144 2157 +13
+ Misses 1008 1005 -3
Partials 49 49
☔ View full report in Codecov by Sentry. |
Syed-Ali-Abbas-Zaidi
force-pushed
the
Ali-Abbas/react-router-upgrade
branch
2 times, most recently
from
435827b to
1aeb7c0
Compare
zawan-ila
approved these changes
Oct 9, 2023
| let store; | ||
|
|
||
| const createWrapper = (state) => { | ||
| store = mockStore(state); | ||
| mockOnSubmit = jest.fn(); |
There was a problem hiding this comment.
Why do you remove this mock?
There was a problem hiding this comment.
This was unnecessary, mockOnSubmit was used to mock the createCourse behavior but there were no assertions being made. CreateCoursePage component was already defining createCourse as an empty function in its default props, so there was no need to mock it.
But if you still suggest bringing this back there are no objections from my side as it will not affect the router upgrade. :)
AfaqShuaib09
approved these changes
Oct 10, 2023
Syed-Ali-Abbas-Zaidi
force-pushed
the
Ali-Abbas/react-router-upgrade
branch
from
17e84a6 to
3df392a
Compare
Syed-Ali-Abbas-Zaidi
force-pushed
the
Ali-Abbas/react-router-upgrade
branch
from
9444dbe to
fb93ee0
Compare
…to Ali-Abbas/react-router-upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
React Router Upgrade to v6.
Description
This PR upgrades React Router from
v5tov6.