Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error code expecting wrong data shape #390

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jansenk
Copy link
Contributor

@jansenk jansenk commented Jan 10, 2025

frontend was expecting gradeStatus lockStatus and gradeData to be wrapped in a submissionStatus object. They are not.

manual reproduction:

  • Have the ora grading MFE installed locally and go to the grading for an ORA with at least one available submission
  • Click "start Grading"
  • Go to the LMS django admin page for submission grading locks
  • change the user ID for the lock owner to some random string
  • attempt to submit a grade

before change: page crashes, error about "iconAfter"
after change: error handled

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fb06133) to head (3de6821).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines         1085      1085           
  Branches       166       165    -1     
=========================================
  Hits          1085      1085           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants