-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paragon table deprecation updation #246
Paragon table deprecation updation #246
Conversation
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 108 -2
Lines 1277 1255 -22
Branches 251 247 -4
=========================================
- Hits 1277 1255 -22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a fine change - the owning team should also review so they're aware of the change, it should be tested by Fed-BOM and we can get it in. I did a cursory review.
My apology for add 4 commits to this pr. I was having trouble starting the process. I had to fix a couple of unrelated bugs for this PR. I would like like to go through the UI with @muselesscreator before approving this pr. |
We can use |
If the new table includes the summary display, we should remove our custom one |
aaaaactually... we need to hide the paragon one, as we have filters that are not taken into account in the datatable's filters (course members, etc) |
I have a fix for the row status as well as test updates. Would you be comfortable with me pushing them into this branch before merge? @abdullahwaheed |
61c73b5
to
464c190
Compare
Ticket
Migrate off deprecated Paragon components
What has changed
Removed deprecated
Table
component of paragon and updated it withDataTable
References
Paragon Table
Paragon DataTable