Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragon table deprecation updation #246

Merged
merged 10 commits into from
Jun 30, 2022

Conversation

abdullahwaheed
Copy link
Contributor

Ticket

Migrate off deprecated Paragon components

What has changed

Removed deprecated Table component of paragon and updated it with DataTable

References

Paragon Table
Paragon DataTable

@abdullahwaheed abdullahwaheed self-assigned this Jun 16, 2022
@abdullahwaheed abdullahwaheed requested a review from a team as a code owner June 16, 2022 09:40
@abdullahwaheed abdullahwaheed requested a review from a team June 16, 2022 09:40
@abdullahwaheed abdullahwaheed changed the title Abdullahwaheed/paragon table deprecations Paragon table deprecation updation Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #246 (3c6a07c) into master (bf70fd1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #246   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       108    -2     
  Lines         1277      1255   -22     
  Branches       251       247    -4     
=========================================
- Hits          1277      1255   -22     
Impacted Files Coverage Δ
...nents/GradesView/EditModal/OverrideTable/index.jsx 100.00% <ø> (ø)
...c/components/GradesView/GradebookTable/messages.js 100.00% <ø> (ø)
src/data/constants/app.js 100.00% <ø> (ø)
...ponents/BulkManagementHistoryView/HistoryTable.jsx 100.00% <100.00%> (ø)
src/components/GradesView/GradebookTable/index.jsx 100.00% <100.00%> (ø)
src/utils/StrictDict.js 100.00% <100.00%> (ø)
src/data/actions/testUtils.js
src/data/thunkActions/testUtils.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf70fd1...3c6a07c. Read the comment docs.

Copy link
Contributor

@davidjoy davidjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fine change - the owning team should also review so they're aware of the change, it should be tested by Fed-BOM and we can get it in. I did a cursory review.

@leangseu-edx
Copy link
Contributor

My apology for add 4 commits to this pr. I was having trouble starting the process. I had to fix a couple of unrelated bugs for this PR. I would like like to go through the UI with @muselesscreator before approving this pr.

Screen Shot 2022-06-28 at 11 50 03 AM

@abdullahwaheed
Copy link
Contributor Author

My apology for add 4 commits to this pr. I was having trouble starting the process. I had to fix a couple of unrelated bugs for this PR. I would like like to go through the UI with @muselesscreator before approving this pr.

Screen Shot 2022-06-28 at 11 50 03 AM

We can use DataTable.Table which will use legacy Table and it won't add Items count in the table

@muselesscreator
Copy link
Contributor

If the new table includes the summary display, we should remove our custom one

@muselesscreator
Copy link
Contributor

aaaaactually... we need to hide the paragon one, as we have filters that are not taken into account in the datatable's filters (course members, etc)

@muselesscreator
Copy link
Contributor

I have a fix for the row status as well as test updates. Would you be comfortable with me pushing them into this branch before merge? @abdullahwaheed

@muselesscreator muselesscreator force-pushed the abdullahwaheed/paragon-table-deprecations branch from 61c73b5 to 464c190 Compare June 30, 2022 16:44
@muselesscreator
Copy link
Contributor

image

@leangseu-edx leangseu-edx merged commit bbb7e89 into master Jun 30, 2022
@leangseu-edx leangseu-edx deleted the abdullahwaheed/paragon-table-deprecations branch June 30, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants