-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing: Using Paragon CSS External Hosting (JavaScript-based configuration) #707
Closed
PKulkoRaccoonGang
wants to merge
1
commit into
openedx:master
from
PKulkoRaccoonGang:Peter_Kulko/implementation-of-design-tokens
+4,899
−2,400
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
module.exports = { | ||
PARAGON_THEME_URLS: { | ||
core: { | ||
urls: { | ||
default: 'https://cdn.jsdelivr.net/npm/@openedx/paragon@alpha/dist/core.min.css', | ||
}, | ||
}, | ||
defaults: { | ||
light: 'light', | ||
dark: 'dark', | ||
}, | ||
variants: { | ||
light: { | ||
urls: { | ||
default: 'https://cdn.jsdelivr.net/npm/@openedx/paragon@alpha/dist/light.min.css', | ||
}, | ||
}, | ||
dark: { | ||
urls: { | ||
default: 'https://cdn.jsdelivr.net/npm/@edx/brand-edx.org@alpha/dist/light.min.css', | ||
}, | ||
}, | ||
}, | ||
}, | ||
}; |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ | |
"extends @edx/browserslist-config" | ||
], | ||
"scripts": { | ||
"build": "fedx-scripts webpack", | ||
"build": "sh run-build-for-gh-deps.sh", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, these seem to be temporary changes and should be reverted at release. |
||
"i18n_extract": "fedx-scripts formatjs extract", | ||
"lint": "fedx-scripts eslint --ext .js --ext .jsx .", | ||
"lint:fix": "fedx-scripts eslint --ext .js --ext .jsx . --fix", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
#!/bin/bash | ||
|
||
log() { | ||
echo "=============================== $1 ===============================" | ||
} | ||
|
||
run_command() { | ||
echo "\$ $1" | ||
eval $1 | ||
} | ||
|
||
log "Starting deployment script" | ||
run_command "pwd" | ||
|
||
# frontend-platform | ||
log "Processing frontend-platform" | ||
run_command "cd node_modules/@edx/" || exit | ||
log "Current directory: $(pwd)" | ||
run_command "rm -rf frontend-platform" | ||
run_command "mkdir frontend-platform" || exit | ||
run_command "ls -l" | ||
run_command "git clone -b Peter_Kulko/design-tokens-support --single-branch https://github.com/raccoongang/frontend-platform.git frontend-platform-temp" | ||
run_command "cd frontend-platform-temp" || exit | ||
log "Current directory: $(pwd)" | ||
run_command "cat package.json" || exit | ||
run_command "ls -l" | ||
run_command "cp -r dist/. ../frontend-platform/" || exit | ||
run_command "cd .." || exit | ||
run_command "ls -l" | ||
log "Current directory: $(pwd)" | ||
run_command "rm -rf frontend-platform-temp" | ||
run_command "cd frontend-platform" || exit | ||
run_command "ls -l" | ||
run_command "cd ../../.." | ||
log "Current directory: $(pwd)" | ||
|
||
# frontend-build | ||
log "Processing frontend-build" | ||
run_command "cd node_modules/@openedx/" || exit | ||
log "Current directory: $(pwd)" | ||
run_command "rm -rf frontend-build" | ||
run_command "git clone -b dcoa/design-tokens-support --single-branch https://github.com/eduNEXT/frontend-build.git" | ||
run_command "cd frontend-build" || exit | ||
log "Current directory: $(pwd)" | ||
run_command "npm ci" | ||
run_command "cd ../../.." || exit | ||
log "Current directory: $(pwd)" | ||
|
||
# paragon | ||
log "Processing paragon" | ||
run_command "ls -l" | ||
run_command "cd node_modules/@openedx/" || exit | ||
log "Current directory: $(pwd)" | ||
run_command "rm -rf paragon" | ||
run_command "mkdir -p paragon" | ||
run_command "cd paragon" || exit | ||
log "Current directory: $(pwd)" | ||
run_command "npm pack @openedx/[email protected]" | ||
run_command "tar -xzf openedx-paragon-23.0.0-alpha.2.tgz --strip-components=1" | ||
run_command "rm openedx-paragon-23.0.0-alpha.2.tgz" | ||
run_command "cd ../../.." || exit | ||
log "Current directory: $(pwd)" | ||
|
||
# frontend-component-header | ||
log "Processing frontend-component-header" | ||
run_command "cd node_modules/@edx/" || exit | ||
log "Current directory: $(pwd)" | ||
run_command "rm -rf frontend-component-header" | ||
run_command "mkdir frontend-component-header" || exit | ||
run_command "git clone -b Peter_Kulko/support-design-tokens --single-branch https://github.com/PKulkoRaccoonGang/frontend-component-header.git frontend-component-header-temp" | ||
run_command "cd frontend-component-header-temp" || exit | ||
log "Current directory: $(pwd)" | ||
run_command "cp -r dist ../frontend-component-header/" || exit | ||
run_command "cp -r package.json ../frontend-component-header/" || exit | ||
run_command "cd .." | ||
run_command "rm -rf frontend-component-header-temp" | ||
run_command "cd ../.." || exit | ||
log "Current directory: $(pwd)" | ||
|
||
# frontend-component-footer | ||
log "Processing frontend-component-footer" | ||
run_command "cd node_modules/@edx/" || exit | ||
log "Current directory: $(pwd)" | ||
run_command "rm -rf frontend-component-footer" | ||
run_command "mkdir frontend-component-footer" || exit | ||
run_command "git clone -b Peter_Kulko/support-design-tokens --single-branch https://github.com/PKulkoRaccoonGang/frontend-component-footer.git frontend-component-footer-temp" | ||
run_command "cd frontend-component-footer-temp" || exit | ||
log "Current directory: $(pwd)" | ||
run_command "cp -r dist ../frontend-component-footer/" || exit | ||
run_command "cp -r package.json ../frontend-component-footer/" || exit | ||
run_command "cd .." | ||
run_command "rm -rf frontend-component-footer-temp" | ||
run_command "cd ../.." || exit | ||
log "Current directory: $(pwd)" | ||
|
||
# webpack | ||
log "Running webpack" | ||
run_command "fedx-scripts webpack" | ||
|
||
log "Deployment script finished." |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this should be a temporary change and should be removed in the final implementation.
And I am not sure about merging it to the master branch directly. Probably, we should use some separate development brunch for pre-stage tasing and further releasing.