Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use shared browserslist configuration #84

Merged

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Sep 21, 2022

Ticket:
Use shared @edx/browserslist-config

  • Removes custom browserslist configuration in favor of using a shared configuration.
  • Removes is-es5 check in CI since ES5 was only needed for IE 11 support which is dropped. The supported browsers defined by the shared configuration all natively support ES6.

This change reduces the resultant asset bundle size.

@openedx-webhooks
Copy link

Thanks for the pull request, @Mashal-m! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 21, 2022
@Mashal-m Mashal-m closed this Oct 4, 2022
@Mashal-m Mashal-m reopened this Oct 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #84 (79e9e66) into master (0130b52) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   82.32%   82.32%           
=======================================
  Files          46       46           
  Lines         679      679           
  Branches      132      132           
=======================================
  Hits          559      559           
  Misses        120      120           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@MaxFrank13 MaxFrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these udpates!

@MaxFrank13 MaxFrank13 merged commit ece65c8 into openedx:master Dec 16, 2022
@abdullahwaheed abdullahwaheed removed engineering review open-source-contribution PR author is not from Axim or 2U labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants