[WIP] [Don't Merge] Use component header

[brian-smith-tcril]

all of the existing header functionality is now working with the shared header component, however, the styles in this PR don't fully match up with the existing header

looking for direction/feedback on what needs to happen for this header style-wise (do i need to override a ton of bootstrap classes?), after that is sorted i'll clean up the code side of things and get it ready to merge

[ihor-romaniuk]

Hi @brian-smith-tcril.
Do you need any help to speed up the merger of this PR and backport these fixes to the olive release?

[brian-smith-tcril]

@ihor-romaniuk there's still the open question of

looking for direction/feedback on what needs to happen for this header style-wise (do i need to override a ton of bootstrap classes?), after that is sorted i'll clean up the code side of things and get it ready to merge

i don't really see the benefit of using a shared component if that also means using a lot of app specific css overrides. ideally the header component style would make sense "out of the box" everywhere it's being used, and provide easy paths for customization (and not require extra overrides for app specific overrides)

[arbrandes]

@connorhaugh, can we get a pair of eyes on this one? Thanks!

[connorhaugh]

looking for direction/feedback on what needs to happen for this header style-wise

I can look into finding exact mockups, screenshots of existing implementations, or something like that? My team could also do a UI review ourselves if that is what is required? What set of resources would solve this open question?

[brian-smith-tcril]

The questions I had were more along the lines of "what are we allowed to change?"

The existing header in course authoring is using styles that mimic the non-mfe studio styles, this shared component does not mimic those styles (see library-authoring post openedx-unsupported/frontend-app-library-authoring#74)

[arbrandes]

@brian-smith-tcril, it would be cool if we can whip up comparison screenshots, in any case.

[brian-smith-tcril]

@arbrandes from olive-demo

Course Authoring:

Library Authoring:

[brian-smith-tcril]

the header component is currently utilizing a paragon actionrow https://paragon-openedx.netlify.app/components/actionrow/

it might make sense to migrate to a navbar https://paragon-openedx.netlify.app/components/navbar/

[connorhaugh]

@brian-smith-tcril Yeah so the issue is that course authoring bar looks a little different than lib-authoring. Here is a current screenshot from prod rn. We'd like to maintain feature parity, but obviously keeping up with requirements and dependancies is important too. Thanks so much! (obv this has edx theme on it)

[connorhaugh]

"what are we allowed to change?"

Don't remove any feature functionality. We will have new designs for studio, maybe eventually.

[KristinAoki]

@brian-smith-tcril This repo is now using a header from frontend-component-header. Is this PR still relevant or should it be closed?

[brian-smith-tcril]

@KristinAoki that's awesome! I'll go ahead and close this.