Skip to content

Commit

Permalink
docs: clarify/update a TODO comment about Meilisearch functionality (#…
Browse files Browse the repository at this point in the history
…1638)

Just a small update to a comment in the code, now that Meilisearch has new functionality that implements a feature we need.
  • Loading branch information
bradenmacdonald authored Jan 29, 2025
1 parent be600a9 commit b7241a1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/search-manager/data/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -473,9 +473,9 @@ export async function fetchTagsThatMatchKeyword({
attributesToSearchOn: ['tags.taxonomy', 'tags.level0', 'tags.level1', 'tags.level2', 'tags.level3'],
attributesToRetrieve: ['tags'],
limit,
// We'd like to use 'showMatchesPosition: true' to know exactly which tags match, but it doesn't provide the
// detail we need; it's impossible to tell which tag at a given level matched based on the returned _matchesPosition
// data - https://github.com/orgs/meilisearch/discussions/550
// TODO: improve this - use 'showMatchesPosition: true' to know exactly which tags match. Previously it didn't
// provide the detail we need (https://github.com/orgs/meilisearch/discussions/550) but it has now been implemented
// in newer versions of Meilisearch. See https://github.com/meilisearch/meilisearch/pull/5005 which fixes it.
});

const tagSearchKeywordsLower = tagSearchKeywords.toLocaleLowerCase();
Expand Down

0 comments on commit b7241a1

Please sign in to comment.