feat: pick required fields from tpa context (#736)

openedx · Jan 17, 2023 · 8ad2678 · 8ad2678
1 parent 49c9126
commit 8ad2678
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/register/RegistrationPage.jsx b/src/register/RegistrationPage.jsx
@@ -8,7 +8,6 @@ import { sendPageEvent } from '@edx/frontend-platform/analytics';
 import {
   getCountryList, getLocale, injectIntl,
 } from '@edx/frontend-platform/i18n';
-import { logError } from '@edx/frontend-platform/logging';
 import { Form, StatefulButton } from '@edx/paragon';
 import PropTypes from 'prop-types';
 import { Helmet } from 'react-helmet';
@@ -105,7 +104,10 @@ const RegistrationPage = (props) => {
     if (!userPipelineDataLoaded) {
       const { pipelineUserDetails } = thirdPartyAuthContext;
       if (pipelineUserDetails && Object.keys(pipelineUserDetails).length !== 0) {
-        setFormFields(prevState => ({ ...prevState, ...pipelineUserDetails }));
+        const { name = '', username = '', email = '' } = pipelineUserDetails;
+        setFormFields(prevState => ({
+          ...prevState, name, username, email,
+        }));
         setUserPipelineDetailsLoaded(true);
       }
     }
@@ -295,9 +297,6 @@ const RegistrationPage = (props) => {
     const fieldErrors = { ...errors };
     let isValid = !focusedFieldError;
     Object.keys(payload).forEach(key => {
-      if (!['name', 'email', 'username', 'password', 'country'].includes(key)) {
-        logError(`Key ${key} found in the payload`);
-      }
       if (!payload[key]) {
         fieldErrors[key] = intl.formatMessage(messages[`empty.${key}.field.error`]);
       }

diff --git a/src/register/tests/RegistrationPage.test.jsx b/src/register/tests/RegistrationPage.test.jsx
@@ -14,7 +14,6 @@ import renderer from 'react-test-renderer';
 import configureStore from 'redux-mock-store';
 
 import { AUTHN_PROGRESSIVE_PROFILING, COMPLETE_STATE, PENDING_STATE } from '../../data/constants';
-import initializeMockLogging from '../../setupTest';
 import {
   backupRegistrationFormBegin,
   clearUsernameSuggestions,
@@ -28,8 +27,6 @@ import {
 import RegistrationFailureMessage from '../RegistrationFailure';
 import RegistrationPage from '../RegistrationPage';
 
-const { loggingService } = initializeMockLogging();
-
 jest.mock('@edx/frontend-platform/analytics');
 jest.mock('@edx/frontend-platform/i18n', () => ({
   ...jest.requireActual('@edx/frontend-platform/i18n'),
@@ -98,7 +95,6 @@ describe('RegistrationPage', () => {
 
   beforeEach(() => {
     store = mockStore(initialState);
-    loggingService.logError.mockReset();
     configure({
       loggingService: { logError: jest.fn() },
       config: {