-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paragon form component deprecations #843
Conversation
Codecov ReportBase: 82.73% // Head: 82.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 353 353
Lines 8484 8537 +53
Branches 1893 1910 +17
==========================================
+ Hits 7019 7062 +43
- Misses 1436 1446 +10
Partials 29 29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/components/LmsConfigurations/BlackboardIntegrationConfigForm.jsx
Outdated
Show resolved
Hide resolved
@@ -144,8 +143,14 @@ class FileInput extends React.Component { | |||
</Button> | |||
</> | |||
)} | |||
<Form.Text>{description}</Form.Text> | |||
{hasError && ( | |||
<Form.Control.Feedback icon={<Error className="mr-1" />}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[curious] Why not use the default icon that Form.Control.Feedback
uses versus overriding the default invalid icon? Same question applies to all uses of Form.Control.Feedback
that passes an <Error />
. Because isInvalid
is passed to the top-level Form.Group
, the default icon that Form.Control.Feedback
uses should be the correct icon already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/components/LmsConfigurations/BlackboardIntegrationConfigForm.jsx
Outdated
Show resolved
Hide resolved
src/components/LmsConfigurations/BlackboardIntegrationConfigForm.jsx
Outdated
Show resolved
Hide resolved
src/components/LmsConfigurations/BlackboardIntegrationConfigForm.jsx
Outdated
Show resolved
Hide resolved
src/components/SamlProviderConfiguration/SamlProviderConfigForm.jsx
Outdated
Show resolved
Hide resolved
src/components/SamlProviderConfiguration/SamlProviderConfigForm.jsx
Outdated
Show resolved
Hide resolved
src/components/SamlProviderConfiguration/SamlProviderConfigForm.jsx
Outdated
Show resolved
Hide resolved
… into abdullah/paragon-form-deprecations
its outdated. created a new PR #933 |
Ticket
Migrate off deprecated Paragon components
What has changed
Updated deprecated
ValidationFormGroup
toForm.Group
,Input
toForm.Control
andCheckbox
toForm. CheckBox
.Tested on edx.org theme.
Screenshots