Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linting and JS errors due to paragon modal deprecation pr #1170

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

adamstankiewicz
Copy link
Member

Description

A PR was merged a few days ago with several linting issues, many of which would result in JS errors. These changes were released to production about 8 hours ago. We are seeing these errors creep up in New Relic reporting, preventing critical user flows.

This PR ensures all linting errors are resolved for this project, resolving those code paths with possible JS bugs due to missing Spinner imports.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11bfeaf) 85.44% compared to head (db55061) 85.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1170   +/-   ##
=======================================
  Coverage   85.44%   85.44%           
=======================================
  Files         497      497           
  Lines       10756    10756           
  Branches     2256     2256           
=======================================
  Hits         9190     9190           
  Misses       1523     1523           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz merged commit 559308a into master Feb 12, 2024
6 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/fix-forward-modal-paragon branch February 12, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants