-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:added toggle methods to basemodel #293
Closed
Theo-flux
wants to merge
10
commits into
openedx:master
from
Theo-flux:theo-flux/toggles-add-methods-290
Closed
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8014609
feat: added toggle methods to basemodel
Theo-flux a48dc14
Merge branch 'master' into theo-flux/toggles-add-methods-290
e0d ce556a8
Merge branch 'master' into theo-flux/toggles-add-methods-290
e0d c370991
test:toggle methods' testcase in BaseWaffleTest class
Theo-flux 9f0b6ae
test: added test_toggle_methods_with_disabled_waffle in BaseWaffleTest
Theo-flux 08ce0d9
refactor: is_disabed changed to is_disabled
Theo-flux 60ee15c
refactor: removed whitespace from file.
Theo-flux 85dbd91
Merge branch 'master' into theo-flux/toggles-add-methods-290
robrap e636210
fix: is_toggle_on/of changed to is_toggled_on/of
Theo-flux 4d4c17e
fix: is_toggle_on/of changed to is_toggled_on/of
Theo-flux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrap marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Theo-flux: This comment is out of sync. Rather than updating it, I think the assertions are clear enough as-is and you could simply delete all of these
# test ...
comments from these two tests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Theo-flux? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Theo-flux: I'd love to have you be able to land this. Checking in one more time. Otherwise - I may end up taking this over at some point. Just let me know. Thanks.