fix: exclude 'course_key' field from the django admin form on course_action_state #36218
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrepca
reviewed
Feb 4, 2025
| def get_queryset(self, request): | ||
| # For any query against this table, remove course_key field | ||
| # because that field might have bad data in it. | ||
| qs =CourseRerunState.objects.defer('course_key') |
There was a problem hiding this comment.
Extra space here needed after the = sign. Are we concerned with this introducing any latency whatsoever? Is it better to delete the row instead, is what I'm getting to.
There was a problem hiding this comment.
I am not concerned with latency with this change. I believe if this change works, the change to db should be immediate.
I think we should try to merge this PR, let me self-serve, before we ask you to delete from the stage environment directly.
schenedx
force-pushed
the
schen/TNL-11876-2
branch
4 times, most recently
from
e3462b3 to
3351d41
Compare
schenedx
force-pushed
the
schen/TNL-11876-2
branch
from
3351d41 to
77f5d7d
Compare
|
The bad piece of data on stage is now updated to something that won't result in 500 error. This change is no longer needed. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change, the course_action_state django admin form will not retrieve "course_key" field from the database. This is desired to use the django admin form to delete the erroneous data.
Context
There is a piece of bad data stored on edx.org stage environment in the database table
course_action_state_coursererunstate. The course_key value is an invalid opaque key. Because of this bad piece of data, the edX staff view of the edx studio home page fails to load any course runs. We want to use this change on the django admin to bypass the bad course_key value, so we can delete the bad piece of data in the table named above.Testing instructions
This change is tested on local machine with erroneous data stored on local mysql database.