Bszabo/course optimizer tests #36175
Open
+198
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bszabo
requested review from
saadyousafarbi,
rayzhou-bit,
hinakhadim and
Faraz32123
schenedx
reviewed
Jan 27, 2025
| LOGGER.debug(f'[Link Check] request batch {i // batch_size + 1} of {url_count // batch_size + 1}') | ||
| batch_results = await _validate_batch(batch, course_key) | ||
| responses.extend(batch_results) | ||
| LOGGER.debug(f'[Link Check] request batch {i // batch_size + 1} of {url_count // batch_size + 1}') |
There was a problem hiding this comment.
Should we leave this logging statement here?
Or should we update this logging statement to be recorded on datadog in stage and prod?
There was a problem hiding this comment.
@schenedx What's involved in having it be recorded on Datadog?
schenedx
requested changes
Jan 27, 2025
| def test_http_and_https_recognized_as_studio_url_schemes(self): | ||
| assert True | ||
|
|
||
| @pytest.mark.skip(reason="This test is not yet implemented") |
There was a problem hiding this comment.
Instead of skipping, could you just remove the test case? I think we got enough tests for now.
|
|
||
| def test_url_subsitution_on_containers(self): | ||
| raise NotImplementedError | ||
| # TODO |
There was a problem hiding this comment.
Could you remove the todo? If in the future, we found this test is valuable, we can add it.
|
I've removed all skipped tests and marked comments requesting their removal as resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests, plus one integration test, to the Course Optimizer test suite.
Note that the test development task is incomplete. Some tests remain in "skip" state, and there are TODO statements in the test file.