Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enzyme testing replaced by react tester #36159

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jciasenza
Copy link
Contributor

Replaced enzyme display dropdown on toggling dropdown test in Main file for react-renderer tests.

I made PR of this issue #35245

And Testing OK

If something needs to be modified, let me know, thank you!!!
Atte
Juan Carlos (Aulasneo)

Developer Checklist

Test suites passing
Documentation and test plan updated, if applicable
Received code-owner approving review

@openedx-webhooks
Copy link

openedx-webhooks commented Jan 23, 2025

Thanks for the pull request, @jciasenza!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 23, 2025
@jciasenza
Copy link
Contributor Author

I don't understand, locally the changes pass all the tests and those that appear as failures are not files that have been modified.

@robrap
Copy link
Contributor

robrap commented Jan 23, 2025

  1. I'm re-running the failed tests. I think you just hit a flaky test failure.
  2. You may still need to look into the quality failure.

@jciasenza
Copy link
Contributor Author

for example in this case, quality checks/Quality Others (ubuntu-24.04, 3.11, 20) (pull_request), I have not changed anything

@robrap
Copy link
Contributor

robrap commented Jan 23, 2025

You need to click the "Details" link to see what the actual failures are. There are ESlint failures.

Error: /home/runner/work/edx-platform/edx-platform/lms/djangoapps/instructor/static/instructor/ProblemBrowser/components/Main/Main.test.jsx: line 34, col 24, Error - Missing trailing comma. (comma-dangle)
Error: /home/runner/work/edx-platform/edx-platform/lms/djangoapps/instructor/static/instructor/ProblemBrowser/components/Main/Main.test.jsx: line 58, col 24, Error - Missing trailing comma. (comma-dangle)
Error: /home/runner/work/edx-platform/edx-platform/lms/djangoapps/instructor/static/instructor/ProblemBrowser/components/Main/Main.test.jsx: line 64, col 45, Error - Block must not be padded by blank lines. (padded-blocks)
Error: /home/runner/work/edx-platform/edx-platform/lms/djangoapps/instructor/static/instructor/ProblemBrowser/components/Main/Main.test.jsx: line 83, col 24, Error - Missing trailing comma. (comma-dangle)

@jciasenza
Copy link
Contributor Author

@robrap Now they passed the tests!!! Thaks!!!

@robrap
Copy link
Contributor

robrap commented Jan 23, 2025

[inform] I create the following ticket to fix the flaky test failure issue:

package.json Outdated Show resolved Hide resolved
@jciasenza
Copy link
Contributor Author

Hello @brian-smith-tcril, when you can check, I think this PR would be resolved now, Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants