-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: advanced editor styling on library authoring [FC-0076] #36146
Merged
ChrisChV
merged 9 commits into
openedx:master
from
open-craft:rpenido/fal-4012-fix-advanced-editor-styling
Jan 30, 2025
+54
−10
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
aa0acf7
fix: advanced editor styling on library authoring
rpenido db53e68
fix: add CMS_ROOT_URL
rpenido f6659f3
fix: issues with multiple scroll bars
rpenido c7f5325
fix: include fix for google-calendar
rpenido f92d488
fix: add CMS_ROOT_URL to common and production env
rpenido 19d59f6
Merge branch 'master' into rpenido/fal-4012-fix-advanced-editor-styling
rpenido 6a2721a
fix: double scrollbars on chrome
rpenido 8463317
Merge branch 'master' into rpenido/fal-4012-fix-advanced-editor-styling
ChrisChV 9d12159
Merge branch 'master' into rpenido/fal-4012-fix-advanced-editor-styling
ChrisChV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
<!DOCTYPE html> | ||
|
||
<html> | ||
<!-- Set the height of the iframe to 100% of the viewport height to avoid an extra scrollbar --> | ||
<html style="height: 100vh;"> | ||
<head> | ||
<!-- Open links in a new tab, not this iframe --> | ||
<base target="_blank"> | ||
|
@@ -81,8 +82,11 @@ | |
href="https://stackpath.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css"> | ||
<!-- Capa Problem Editing requires CodeMirror --> | ||
<link rel="stylesheet" href="{{ lms_root_url }}/static/js/vendor/CodeMirror/codemirror.css"> | ||
<!-- Built-in XBlocks (and some plugins) depends on LMS CSS --> | ||
<link rel="stylesheet" href="{{ lms_root_url }}/static/css/lms-course.css"> | ||
Comment on lines
-84
to
-85
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the editor iframe, the I didn't find where this was used to check the results, but the Unit Outline and the Course View seem okay. We can't add this conditionally if needed. |
||
<!-- Additional CSS for the XBlock Editor on the Library Authoring --> | ||
<link rel="stylesheet" href="{{ cms_root_url }}/static/studio/css/vendor/normalize.css"> | ||
<link rel="stylesheet" href="{{ cms_root_url }}/static/studio/css/studio-main-v1.css" /> | ||
<link rel="stylesheet" href="{{ cms_root_url }}/static/studio/css/course-unit-mfe-iframe-bundle.css" /> | ||
|
||
<!-- Configure and load MathJax --> | ||
<script type="text/x-mathjax-config"> | ||
MathJax.Hub.Config({ | ||
|
@@ -156,11 +160,13 @@ | |
<!-- The default stylesheet will set the body min-height to 100% (a common strategy to allow for background | ||
images to fill the viewport), but this has the undesireable side-effect of causing an infinite loop via the onResize | ||
event listeners below, in certain situations. Resetting it to the default "auto" skirts the problem.--> | ||
<body style="min-height: auto; background-color: white;"> | ||
<!-- fragment body --> | ||
{{ fragment.body_html | safe }} | ||
<!-- fragment foot --> | ||
{{ fragment.foot_html | safe }} | ||
<body style="min-height: auto; background-color: white;" class="view-container"> | ||
<div class="wrapper xblock-iframe-content"> | ||
<!-- fragment body --> | ||
{{ fragment.body_html | safe }} | ||
<!-- fragment foot --> | ||
{{ fragment.foot_html | safe }} | ||
</div> | ||
<script> | ||
/** | ||
* Map of all URL handlers for this block and its children, keyed by usage | ||
|
@@ -216,7 +222,7 @@ | |
return url; | ||
}, | ||
notify: (eventName, data) => { | ||
/** | ||
/** | ||
* Used in `studio_view` to notify events and errors | ||
**/ | ||
window.parent.postMessage({ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido I think
CMS_ROOT_URL
is a new env variable, right? I think we should add it incms/envs/common.py
, incms/envs/production.py
. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Done here: f92d488