-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Cache images in unit tests #36110
Conversation
Another attempt to stop Dockerhub from rate limiting us in CI. If this works here I'll try to add this caching to other relevant workflows.
Closing and reopening to make sure caching actually works across runs. I'll need to update the cache key after this as it's currently incorrect, but first need to make sure it actually does what it's supposed to. |
This seems to solve the issue, at least in the unit tests. Previous:
Now:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it!
Nice. And even if we do start pulling other Docker images and forget to update the cache key, I don't think that will cause any failures (directly) or correctness issues -- just more risk of rate-limiting again. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Description
Another attempt to stop Dockerhub from rate limiting us in CI. If this works here I'll try to add this caching to other relevant workflows.
Supporting information
openedx/axim-engineering#1350 (comment)
Current attempt is using this action to attempt the cache: https://github.com/marketplace/actions/docker-cache