-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Changes in xblock_v2 to support studio_view [FC-0076] #36029
feat: Changes in xblock_v2 to support studio_view [FC-0076] #36029
Conversation
Thanks for the pull request, @ChrisChV! This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: Ran the testing instructions
- I read through the code
- I checked for accessibility issues
- Includes documentation
…nts on block render
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and reviewed the code and it's working well. The only minor issue I found is that the Google Document XBlock editor modal does not close when I press Save (though it does save).
Thanks! I made a round of testing with multiple blocks and I mapped different specific issues in this document. |
@ChrisChV Ah, perfect. I hope we can find some kind of general fix for the missing styles issue. |
In any case, feel free to merge this tomorrow :) |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Updates to support
studio_view
(editors) in xblock_v2 iframe.studio_view
notify
function inruntime
. This is to avoid errors when saving the XblockSupporting information
Testing instructions
Follow the testing instructions at openedx/frontend-app-authoring#1568
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
N/A