-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0070] rendering library content in unit page #35785
base: master
Are you sure you want to change the base?
feat: [FC-0070] rendering library content in unit page #35785
Conversation
Thanks for the pull request, @ihor-romaniuk! This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
ea6c563
to
7e3ef8a
Compare
7e3ef8a
to
41a4092
Compare
Testing instructions are missing a rebuild of static assets. This PR didn't work for me until I ran |
{ | ||
type: 'handleViewXBlockContent', | ||
payload: { | ||
destination: event.currentTarget.href || '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if we can also send the usageId
as a separate parameter in the payload here, instead of making the MFE parse it (const newUnitId = payload.destination.split('/').pop()
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. We can simplify payload data and reduce extra calculation on the MFE side.
320fc9a
to
e358489
Compare
84df7ac
to
a199471
Compare
294546c
to
6f9d22c
Compare
6f9d22c
to
91e83a7
Compare
91e83a7
to
049bea5
Compare
π¨ Dependencies:
Description
This feature introduces functionalities to improve XBlock interactions within iframes:
Unit_Library_Content.mov
Related Pull Requests
Testing instructions
Note: The change requires rebuilding static assets with
tutor dev exec lms opensx-assets build --env=dev