chore: Adds constant fallbacks to some css variables

openedx · Jan 28, 2025 · 566a5c0 · 566a5c0
1 parent 84dbe96
commit 566a5c0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/xmodule/static/css-builtin-blocks/ProblemBlockDisplay.css b/xmodule/static/css-builtin-blocks/ProblemBlockDisplay.css
@@ -156,7 +156,7 @@
 
 .xmodule_display.xmodule_ProblemBlock div.problem .question-description {
     color: var(--gray-d1, #5e5e5e);
-    font-size: var(--small-font-size);
+    font-size: var(--small-font-size, 80%);
 }
 
 .xmodule_display.xmodule_ProblemBlock div.problem form>label,
@@ -396,7 +396,7 @@
     padding: calc((var(--baseline, 20px) / 2));
     padding-left: calc((var(--baseline, 20px) * 2.3));
     position: relative;
-    font-size: var(--base-font-size);
+    font-size: var(--base-font-size, 18px);
     line-height: normal;
     cursor: pointer;
 }
@@ -1042,7 +1042,7 @@
     align-items: center;
 }
 
-@media (max-width: var(--bp-screen-lg)) {
+@media (max-width: var(--bp-screen-lg, 1024px)) {
     .xmodule_display.xmodule_ProblemBlock div.problem .action .submit-attempt-container {
         max-width: 100%;
         padding-bottom: var(--baseline, 20px);
@@ -1071,7 +1071,7 @@
     margin-top: calc(var(--baseline, 20px) / 2);
     display: inline-block;
     color: var(--gray-d1, #5e5e5e);
-    font-size: var(--medium-font-size);
+    font-size: var(--medium-font-size, 0.9em);
     -webkit-font-smoothing: antialiased;
     vertical-align: middle;
 }
@@ -1140,7 +1140,7 @@
     float: left;
     margin-top: calc(var(--baseline, 20px) / 2);
     padding: calc((var(--baseline, 20px) / 2.5)) calc((var(--baseline, 20px) / 2)) calc((var(--baseline, 20px) / 5)) calc((var(--baseline, 20px) / 2));
-    line-height: var(--base-line-height);
+    line-height: var(--base-line-height, 1.5em);
 }
 
 .xmodule_display.xmodule_ProblemBlock div.problem .notification.success {

diff --git a/xmodule/static/css-builtin-blocks/VideoBlockDisplay.css b/xmodule/static/css-builtin-blocks/VideoBlockDisplay.css
@@ -526,7 +526,7 @@
 .xmodule_display.xmodule_VideoBlock .video .video-wrapper .video-controls .secondary-controls .menu-container .menu li.is-active .speed-option,
 .xmodule_display.xmodule_VideoBlock .video .video-wrapper .video-controls .secondary-controls .menu-container .menu li.is-active .control-lang {
     border-left: calc(var(--baseline, 20px) / 10) solid #0ea6ec;
-    font-weight: var(--font-bold);
+    font-weight: var(--font-bold, 700);
     color: #0ea6ec;
 }
 
@@ -613,7 +613,7 @@
 }
 
 .xmodule_display.xmodule_VideoBlock .video .video-wrapper .video-controls .secondary-controls .volume .volume-slider-container .volume-slider .ui-slider-handle {
-    transition: height var(--tmg-s2) ease-in-out 0s, width var(--tmg-s2) ease-in-out 0s;
+    transition: height var(--tmg-s2, 2s) ease-in-out 0s, width var(--tmg-s2, 2s) ease-in-out 0s;
     left: -5px;
     box-sizing: border-box;
     height: 13px;
@@ -1008,7 +1008,7 @@
 }
 
 .xmodule_display.xmodule_VideoBlock .video-tracks .a11y-menu-container>a {
-    transition: all var(--tmg-f2) ease-in-out 0s;
+    transition: all var(--tmg-f2, 0.25s) ease-in-out 0s;
     font-size: 12px;
     display: block;
     border-radius: 0 3px 3px 0;