-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: organization PUT API AttributeError #410
Conversation
Thanks for the pull request, @jramnai! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@felipemontoya, can you please run the workflows? as it requires approval from a maintainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes themselves look reasonable to me.
Do you know if this has any implications for other services?
Existing organizations updated through the API always end up Active,
regardless of whether or not they were previously active
@felipemontoya, No, I don't know. |
I did a bit of arqueology on this and the behavior was implemented here: As such, this PR does not change the API in any way and downstream services won't be affected. |
I'll merge the PR now @jramnai. If you need a new tagged version let me know as I was expecting to do some housekeeping on the requirement PRs and add a Changelog before releasing. |
@jramnai 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Thanks for merging this @felipemontoya. I'm not looking for a new tagged version right now. |
This fixes #409.
self.request.data
is QueryDict hence it is immutable so we can not addactive: True
.With this PR,
active: True
is added on the serializer side.