feat: new mgmt command to validate default enrollment intentions #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
commented
Jan 25, 2025
Comment on lines
+34
to
+35
| default=30, | ||
| help="How long after a customer's catalog has been updated are we allowed to evaluate the customer." |
There was a problem hiding this comment.
30 minutes is a wild guess, I'll probably take a look at some real life task durations and come up with something more accurate.
pwnage101
force-pushed
the
pwnage101/ENT-9941
branch
4 times, most recently
from
1255aca to
6f5ff84
Compare
Comment on lines
+2729
to
+2736
| def __str__(self): | ||
| """ | ||
| Return human-readable string representation. | ||
| """ | ||
| return ( | ||
| f"<DefaultEnterpriseEnrollmentIntention for customer={self.enterprise_customer.uuid} " | ||
| f"and content_key={self.content_key}>" | ||
| ) |
Comment on lines
96
to
93
| customers = EnterpriseCustomer.objects.annotate( | ||
| catalogs_modified_latest=Greatest( | ||
| Max("enterprise_customer_catalogs__modified"), | ||
| Max("enterprise_customer_catalogs__enterprise_catalog_query__modified"), | ||
| ), | ||
| ).prefetch_related( | ||
| "default_enrollment_intentions", | ||
| ) |
There was a problem hiding this comment.
Will this fetch all enterprise customer records? Can we do it in "reverse" by first identifying only the customers that have any default enrollment intentions?
iloveagent57
approved these changes
Jan 28, 2025
Comment on lines
96
to
99
| customers_with_intentions = DefaultEnterpriseEnrollmentIntention.objects.values_list( | ||
| "enterprise_customer__uuid", | ||
| ) | ||
| customers_with_intentions = [values[0] for values in customers_with_intentions] |
There was a problem hiding this comment.
FYI you can pass in flat=True to values list if you're only selecting a single column, and that will give you back singles values instead of 1-tuples.
pwnage101
force-pushed
the
pwnage101/ENT-9941
branch
from
af3a218 to
8a36ff6
Compare
Introduced validate_default_enrollment_intentions.py to check that all DefaultEnterpriseEnrollmentIntention objects have a valid content_key which actually belongs to at least one of the related customer's catalogs. ENT-9941
pwnage101
force-pushed
the
pwnage101/ENT-9941
branch
from
8a36ff6 to
553eef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced validate_default_enrollment_intentions.py to check that all DefaultEnterpriseEnrollmentIntention objects have a valid content_key which actually belongs to at least one of the related customer's catalogs.
ENT-9941