Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add monitoring signals for plugins #467

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Dec 4, 2024

Description:

Adds signals monitoring_support_process_request,
monitoring_support_process_response, and
monitoring_support_process_exception to the
MonitoringSupportMiddleware to enable plugging in
monitoring capabilities.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns:

I decided to go with monitoring/signals.py vs monitoring/signals/signals.py to clean up the imports when using the signals, especially given the length of the signal names.

Adds signals monitoring_support_process_request,
monitoring_support_process_response, and
monitoring_support_process_exception to the
MonitoringSupportMiddleware to enable plugging in
monitoring capabilities.
@robrap robrap merged commit a2ab5d6 into master Dec 4, 2024
7 checks passed
@robrap robrap deleted the robrap/add-monitoring-signals branch December 4, 2024 20:36
@robrap robrap mentioned this pull request Dec 10, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants