-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update RTD config. #418
Conversation
56e10e6
to
0b3d881
Compare
c60507b
to
5eb7e4b
Compare
- method: pip | ||
path: . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dianakhuang: Did you find any information about this, or are you just following what was done in edx-platform?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just following what was done in edx-platform under the assumption that getting a working RTD config was more important than worrying about whether we may have redundant config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this is needed in edx-platform because we have to pip install .
in order to add all the plugin entrypoints that edx-platform needs to properly start up django. Which we do to generate the module docs now. We shouldn't generally need this in other repos.
os: "ubuntu-22.04" | ||
tools: | ||
python: "3.8" | ||
|
||
python: | ||
version: 3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want to remove this redundant version declaration.
RTD updated their config format. This updates the cookiecutter to match their recommendations. #416
5eb7e4b
to
3b1eb8c
Compare
Closing as a dupe of #419 |
RTD updated their config format. This updates
the cookiecutter to match their recommendations.
#416
Merge checklist:
Check off if complete or not applicable: