feat: performance tuning credentials admin #2684
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds a single index to UserCredential.credential_id. You would think this would be implicitly indexed by the presence of a unique_together, but it isn't. I don't want to get overly exuberant with indices because we have a lot of costly writes during grading already, but I can see using SQL `EXPLAIN` that making this change does convert the django admin page from `using filesort` to `using index`, so theoretically this should speed it up. If it doesn't, I will try a different approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a single index to UserCredential.credential_id. You would think this would be implicitly indexed by the presence of a unique_together, but it isn't. I don't want to get overly exuberant with indices because we have a lot of costly writes during grading already, but I can see using SQL
EXPLAINthat making this change does convert the django admin page fromusing filesorttousing index, so theoretically this should speed it up. If it doesn't, I will try a different approach.Run JavaScript tests locally with Karma
There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.
make test-karma