Add models for operator dashboard #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmtcril how does this works on local and dev? Where you able to query the data locally? |
bmtcril
force-pushed
the
bmtcril/operator_dash_enhancements
branch
2 times, most recently
from
36cbeea to
00762f3
Compare
bmtcril
commented
Apr 24, 2024
bmtcril
commented
Apr 24, 2024
| config( | ||
| materialized="materialized_view", | ||
| schema=env_var("ASPECTS_XAPI_DATABASE", "xapi"), | ||
| engine=get_engine("SummingMergeTree()"), |
There was a problem hiding this comment.
I think this is our first use of a SummingMergeTree. I'm still trying to confirm this is all working as expected.
There was a problem hiding this comment.
Were you able to confirm that this does what we want? It looks correct to me but I'm trying to compare this to the AggregatingMergeTree table engine.
There was a problem hiding this comment.
There's something off with it when there is new data coming in, I'm still debugging it
Ian2012
approved these changes
Apr 25, 2024
bmtcril
force-pushed
the
bmtcril/operator_dash_enhancements
branch
6 times, most recently
from
5356cbc to
fafa728
Compare
SoryRawyer
approved these changes
Apr 26, 2024
bmtcril
force-pushed
the
bmtcril/operator_dash_enhancements
branch
from
fafa728 to
2fa70fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes a number of user_pii fields that are currently unused and cause ClickHouse to fail to build them when run at scale.