-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add graded and block_type to dim_course_blocks #48
Conversation
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
d0db5e2
to
0f09ba8
Compare
b92c80c
to
d058b4e
Compare
0f09ba8
to
c9b2347
Compare
00a2bd7
to
91e226d
Compare
c9b2347
to
cbd89e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but can you add these fields to the documentation in schema.yml
?
6533db1
to
7026d9f
Compare
cbd89e8
to
961c482
Compare
961c482
to
e8352e1
Compare
e8352e1
to
eb050a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have that one comment about the documentation. Otherwise, looks good!
eb050a2
to
b4315d7
Compare
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds the fields graded and block_type to the dim_course_blocks model