-
Notifications
You must be signed in to change notification settings - Fork 30
feat!: remove Transifex calls for OEP-58 | FC-0012 #341
feat!: remove Transifex calls for OEP-58 | FC-0012 #341
Conversation
Thanks for the pull request, @hopewise! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 63.58% 63.77% +0.19%
==========================================
Files 34 33 -1
Lines 335 334 -1
Branches 74 74
==========================================
Hits 213 213
+ Misses 115 114 -1
Partials 7 7 ☔ View full report in Codecov by Sentry. |
b7dd71b
to
be4f83e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brian-smith-tcril @timmc-edx this PR is both ready for merge and ready to be deployed by 2U.
@openedx/revenue-squad @spencertiberi this cannot be merged until a code owner approves it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI edx-internal changes to use atlas for this MFE has been done in https://github.com/edx/edx-internal/pull/10408
210babb
into
openedx-unsupported:master
@hopewise 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Breaking change!
This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.
Changes
tx pull
andtx push
commands from the micro-frontend in favorof the
atlas pull
command..json
files will be committed into the repos.src/i18n/index.js
should export and empty array so themake pull_translations
override it with the dynamic list of languages.OPENEDX_ATLAS_PULL
flag to makeatlas pull
the default.Makefile
targets and other files.Test results
make pull_translations
works as expected.make pull_translations test results
Merge timeline
This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.
The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.
Keep this pull request as a draft to prevent accidental merge.
Pre-merge checklist
References
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.