Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Target changed to dev image for devstack for LMS & Studio #1018

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

zubairshakoorarbisoft
Copy link
Contributor

Task description:
openedx/edx-platform#31737

How to test

  • Go to devstack
  • Make sure you have latest edx-platform repo in workspace
  • Now, all set to up LMS
  • Run make dev.up.lms

Commands to test

  • Make sure make dev.shell.lms is running fine and opening shell
  • Make sure make dev.provision.lms is running fine
  • Make sure make dev.logs.lms is not throwing any errors, it should run fine and showing logs
  • In case, you see issue on dashboard, just open lms shell and run migrations and re-try
  • Migration command --> python manage.py lms migrate

@zubairshakoorarbisoft zubairshakoorarbisoft changed the title Target changed to dev image for devstack Target changed to dev image for devstack for LMS Feb 14, 2023
@zubairshakoorarbisoft zubairshakoorarbisoft force-pushed the zshkoor/devstack-lms-dev-target-image branch from f63991b to a7ad46b Compare February 20, 2023 10:58
@zubairshakoorarbisoft zubairshakoorarbisoft marked this pull request as ready for review February 21, 2023 07:18
Copy link
Contributor

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also look for any other targets using default edxapp_env and update those in the Makefile such as dev.migrate.lms/studio etc.

docker-compose.yml Outdated Show resolved Hide resolved
@zubairshakoorarbisoft zubairshakoorarbisoft changed the title Target changed to dev image for devstack for LMS Target changed to dev image for devstack for LMS & Studio Mar 9, 2023
@zubairshakoorarbisoft zubairshakoorarbisoft force-pushed the zshkoor/devstack-lms-dev-target-image branch from d7fb5b1 to a9a6bdb Compare March 10, 2023 14:02
@zubairshakoorarbisoft zubairshakoorarbisoft force-pushed the zshkoor/devstack-lms-dev-target-image branch from 2479c17 to 5bbbc44 Compare March 16, 2023 12:14
@awais786 awais786 dismissed UsamaSadiq’s stale review March 16, 2023 13:20

Changed implemented

@zubairshakoorarbisoft zubairshakoorarbisoft merged commit 67fe7e8 into master Mar 16, 2023
@zubairshakoorarbisoft zubairshakoorarbisoft deleted the zshkoor/devstack-lms-dev-target-image branch March 16, 2023 13:24
XLAR-8 pushed a commit to XLAR-8/devstack that referenced this pull request Jul 26, 2023
…supported#1018)

* feat: target  dev image changed for LMS and Studio

* fix: env variables updated for lms and cms

* fix: rollback pip.txt changes

* fix: lms_watcher target updated
nsprenkle pushed a commit that referenced this pull request Nov 21, 2023
* feat: target  dev image changed for LMS and Studio

* fix: env variables updated for lms and cms

* fix: rollback pip.txt changes

* fix: lms_watcher target updated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create LMS and Studio Docker images from Dockerfile
3 participants